Register stub setgeopoint implementation that does nothing #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default stub from JavaRosa writes a string out which fails if the target node type is e.g. geopoint.
yanokwa
approved these changes
Sep 9, 2019
|
Can you confirm you tried this fix with pyxform running Validate? |
|
I've tried to add more context to the comment and I hope that helps.
I tried it just with Validate but did not put the patched Validate in pyxform. I don't think that would be any different than validating standalone. |
|
Confirmed that running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default stub from JavaRosa writes a string out which fails if the target node type is e.g. geopoint.
Needed to address XLSForm/pyxform#351
What has been done to verify that this works as intended?
I tried metadata.xml.txt before the fix, confirmed it fails because of a casting issue, applied the fix, confirmed that it works.
Why is this the best possible solution? Were any other approaches considered?
I considered changing the stub implementation in JavaRosa to write something in geopoint format, probably 0 0 0 0, but I think it's helpful for JR tests to have the "no implementation" text and I think it makes it more likely clients would notice they've made a mistake if they don't register their own action handler.
For Validate, having the action do nothing is ideal. We can't do that at the JR level because it doesn't allow us to test that the basic action setup (abstract SetGeopointAction class) works.
Are there any risks to merging this code? If so, what are they?
I can't think of any. This only affects forms that have setgeopoint actions. It adds support for those forms and I think the only risk is that it doesn't work in some contexts.